PHPLARA-73 Make id/_id column aliasing overridable via Grammar - #3539
Merged
Conversation
Delegate the top-level `id` to `_id` column rename in `Builder::compileWheres()` to `Grammar::prepareFieldsForQuery()` so users can extend the Grammar to disable the aliasing when documents have a business `id` field alongside `_id`.
GromNaN
force-pushed
the
phplara-73-overridable-id-aliasing
branch
from
July 3, 2026 14:58
93f5d08 to
d013a90
Compare
paulinevos
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top-level
idto_idcolumn rename inBuilder::compileWheres()was hardcoded, which caused data corruption for users whose MongoDB documents have a businessidfield alongside_id(see #3392).This delegates the aliasing to
Grammar::prepareFieldsForQuery(), which is already the public overridable API (introduced in #3476). Users who need to disable the aliasing can now extend the Grammar class, consistent with Laravel's query builder architecture.The
alias_idconnection config option (proposed in #3472) is not the right approach becausecompileWheres()runs beforeGrammar::prepareFieldsForQuery()at other call sites, so the Grammar hook would have received a payload whereidhad already been replaced by_id.Ticket: https://jira.mongodb.org/browse/PHPLARA-73