Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Eloquent/Builder.php
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,9 @@ public function decrement($column, $amount = 1, array $extra = [])
}

/**
* @param (Closure():T)|Expression|null $value
* @param (Closure(\MongoDB\Collection):T)|Expression|null $value
*
* @return ($value is Closure ? T : ($value is null ? Collection : Expression))
* @return ($value is Closure ? (T is CursorInterface ? Collection<int, TModel> : T|TModel|Collection<int, TModel>) : ($value is null ? \MongoDB\Collection : \Illuminate\Contracts\Database\Query\Expression))
*
Comment on lines +226 to 229

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this guy said I guess 😅

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Both points fixed:

  • Expression return type now uses \Illuminate\Contracts\Database\Query\Expression (the interface actually returned by $this->query->raw()).
  • For the CursorInterface case, I added a nested conditional: T is CursorInterface ? Collection<int, TModel> : T|TModel|Collection<int, TModel> — PHPStan now correctly infers Collection<int, TModel> and no longer includes CursorInterface in the union.

* @template T
*/
Expand Down
4 changes: 2 additions & 2 deletions src/Query/Builder.php
Original file line number Diff line number Diff line change
Expand Up @@ -1045,9 +1045,9 @@ public function lists($column, $key = null)
}

/**
* @param (Closure():T)|Expression|null $value
* @param (Closure(\MongoDB\Collection):T)|Expression|null $value
*
* @return ($value is Closure ? T : ($value is null ? Collection : Expression))
* @return ($value is Closure ? T : ($value is null ? \MongoDB\Collection : Expression))
*
* @template T
*/
Expand Down
73 changes: 73 additions & 0 deletions tests/PHPStan/BuilderRawTypes.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
<?php

declare(strict_types=1);

namespace MongoDB\Laravel\Tests\PHPStan;

use Illuminate\Database\Query\Expression;
use MongoDB\Collection as MongoDBCollection;
use MongoDB\Laravel\Eloquent\Builder as EloquentBuilder;
use MongoDB\Laravel\Query\Builder as QueryBuilder;
use MongoDB\Laravel\Tests\Models\User;

use function PHPStan\Testing\assertType;

/**
* PHPStan type-level tests for Builder::raw() return and param types.
* These functions are never executed at runtime — they exist to let PHPStan
* validate that the @param and @return types on raw() match the declared signatures.
*/
final class BuilderRawTypes
{
public static function queryBuilderRawNull(QueryBuilder $queryBuilder): void
{
assertType('MongoDB\Collection', $queryBuilder->raw());
}

public static function queryBuilderRawClosureFind(QueryBuilder $queryBuilder): void
{
assertType('MongoDB\Driver\CursorInterface', $queryBuilder->raw(fn (MongoDBCollection $c) => $c->find([])));
}

public static function queryBuilderRawClosureFindOne(QueryBuilder $queryBuilder): void
{
assertType('array|object|null', $queryBuilder->raw(fn (MongoDBCollection $c) => $c->findOne([])));
}

public static function queryBuilderRawExpression(QueryBuilder $queryBuilder): void
{
assertType('Illuminate\Database\Query\Expression', $queryBuilder->raw(new Expression('foo')));
}

/** @param EloquentBuilder<User> $builder */
public static function eloquentBuilderRawNull(EloquentBuilder $builder): void
{
assertType('MongoDB\Collection', $builder->raw());
}

/** @param EloquentBuilder<User> $builder */
public static function eloquentBuilderRawClosureFind(EloquentBuilder $builder): void
{
assertType(
'Illuminate\Database\Eloquent\Collection<int, MongoDB\Laravel\Tests\Models\User>',
$builder->raw(fn (MongoDBCollection $c) => $c->find([])),
);
}

/** @param EloquentBuilder<User> $builder */
public static function eloquentBuilderRawExpression(EloquentBuilder $builder): void
{
assertType('Illuminate\Contracts\Database\Query\Expression', $builder->raw(new Expression('foo')));
}

/** @param EloquentBuilder<User> $builder */
public static function eloquentBuilderRawClosureFindOne(EloquentBuilder $builder): void
{
// PHPStan simplifies User|Collection<int, User>|array|object|null to array|object|null
// because object is a supertype of User and Collection.
assertType(
'array|object|null',
$builder->raw(fn (MongoDBCollection $c) => $c->findOne([])),
);
}
}
Loading