-
Notifications
You must be signed in to change notification settings - Fork 1.4k
PHPORM-492 Fix PHPDoc return and param types for raw() methods #3526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0f83ccf
Fix PHPDoc return and param types for raw() methods
GromNaN d2ad6de
Add PHPStan type tests for Builder::raw() param and return types
GromNaN e5bbc13
Remove weak closure parameter tests from BuilderRawTypes
GromNaN 88408d0
Fix Expression return type in Eloquent\Builder::raw() and add Express…
GromNaN 66b3179
Use Illuminate\Contracts\Database\Query\Expression in Eloquent\Builde…
GromNaN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace MongoDB\Laravel\Tests\PHPStan; | ||
|
|
||
| use Illuminate\Database\Query\Expression; | ||
| use MongoDB\Collection as MongoDBCollection; | ||
| use MongoDB\Laravel\Eloquent\Builder as EloquentBuilder; | ||
| use MongoDB\Laravel\Query\Builder as QueryBuilder; | ||
| use MongoDB\Laravel\Tests\Models\User; | ||
|
|
||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| /** | ||
| * PHPStan type-level tests for Builder::raw() return and param types. | ||
| * These functions are never executed at runtime — they exist to let PHPStan | ||
| * validate that the @param and @return types on raw() match the declared signatures. | ||
| */ | ||
| final class BuilderRawTypes | ||
| { | ||
| public static function queryBuilderRawNull(QueryBuilder $queryBuilder): void | ||
| { | ||
| assertType('MongoDB\Collection', $queryBuilder->raw()); | ||
| } | ||
|
|
||
| public static function queryBuilderRawClosureFind(QueryBuilder $queryBuilder): void | ||
| { | ||
| assertType('MongoDB\Driver\CursorInterface', $queryBuilder->raw(fn (MongoDBCollection $c) => $c->find([]))); | ||
| } | ||
|
|
||
| public static function queryBuilderRawClosureFindOne(QueryBuilder $queryBuilder): void | ||
| { | ||
| assertType('array|object|null', $queryBuilder->raw(fn (MongoDBCollection $c) => $c->findOne([]))); | ||
| } | ||
|
|
||
| public static function queryBuilderRawExpression(QueryBuilder $queryBuilder): void | ||
| { | ||
| assertType('Illuminate\Database\Query\Expression', $queryBuilder->raw(new Expression('foo'))); | ||
| } | ||
|
|
||
| /** @param EloquentBuilder<User> $builder */ | ||
| public static function eloquentBuilderRawNull(EloquentBuilder $builder): void | ||
| { | ||
| assertType('MongoDB\Collection', $builder->raw()); | ||
| } | ||
|
|
||
| /** @param EloquentBuilder<User> $builder */ | ||
| public static function eloquentBuilderRawClosureFind(EloquentBuilder $builder): void | ||
| { | ||
| assertType( | ||
| 'Illuminate\Database\Eloquent\Collection<int, MongoDB\Laravel\Tests\Models\User>', | ||
| $builder->raw(fn (MongoDBCollection $c) => $c->find([])), | ||
| ); | ||
| } | ||
|
|
||
| /** @param EloquentBuilder<User> $builder */ | ||
| public static function eloquentBuilderRawExpression(EloquentBuilder $builder): void | ||
| { | ||
| assertType('Illuminate\Contracts\Database\Query\Expression', $builder->raw(new Expression('foo'))); | ||
| } | ||
|
|
||
| /** @param EloquentBuilder<User> $builder */ | ||
| public static function eloquentBuilderRawClosureFindOne(EloquentBuilder $builder): void | ||
| { | ||
| // PHPStan simplifies User|Collection<int, User>|array|object|null to array|object|null | ||
| // because object is a supertype of User and Collection. | ||
| assertType( | ||
| 'array|object|null', | ||
| $builder->raw(fn (MongoDBCollection $c) => $c->findOne([])), | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this guy said I guess 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Both points fixed:
Expressionreturn type now uses\Illuminate\Contracts\Database\Query\Expression(the interface actually returned by$this->query->raw()).CursorInterfacecase, I added a nested conditional:T is CursorInterface ? Collection<int, TModel> : T|TModel|Collection<int, TModel>— PHPStan now correctly infersCollection<int, TModel>and no longer includesCursorInterfacein the union.