Skip to content

refactor(stage-ui): use public package exports - #2373

Merged
nekomeowww merged 2 commits into
moeru-ai:mainfrom
leaft:refactor/use-public-package-exports
Aug 27, 2026
Merged

refactor(stage-ui): use public package exports#2373
nekomeowww merged 2 commits into
moeru-ai:mainfrom
leaft:refactor/use-public-package-exports

Conversation

@leaft

@leaft leaft commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Description

@proj-airi/stage-ui bypassed two public package boundaries:

  • Stage.vue imported useSettingsLive2d from the stage-ui-live2d source tree.
  • The MCP store imported useLocalStorageManualReset from the stage-shared source tree.

This PR replaces both source-tree imports with their existing public package entries:

  • @proj-airi/stage-ui-live2d
  • @proj-airi/stage-shared/composables

This keeps package consumers independent from another package's internal file layout.

Linked Issues

None.

Additional Context

There is no runtime or visual behavior change.

Verification:

  • sem diff --staged --no-cosmetics -v --file-exts .ts .tsx
  • sem diff --staged --no-cosmetics -v --file-exts .vue
  • pnpm -F @proj-airi/stage-ui typecheck
  • pnpm lint — 0 errors and 7 existing warnings outside this change
  • git diff --check

The full workspace pnpm typecheck was also run. In the isolated worktree it stopped in unchanged electron-vueuse because the generated electron-eventa output was not present. The affected package type check above passed.

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

@leaft
leaft marked this pull request as ready for review August 26, 2026 10:49
@leaft
leaft requested a review from nekomeowww August 26, 2026 10:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e46cf2a2b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/stage-tamagotchi/electron.vite.config.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e5bad29278

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/model-driver-mediapipe/src/three/apply-pose-to-vrm.ts Outdated
@leaft
leaft force-pushed the refactor/use-public-package-exports branch from e5bad29 to f0f9552 Compare August 27, 2026 03:46
@0xSelenicDove 0xSelenicDove added the scope/engineering Scope related to toolchain, workflow, workspace, and CI/CD, deploy, packaging, etc. label Aug 27, 2026 — with ChatGPT Codex Connector
@nekomeowww
nekomeowww merged commit debe401 into moeru-ai:main Aug 27, 2026
11 checks passed
@nekomeowww

Copy link
Copy Markdown
Member

Thanks! I miss you so much, thanks for refactoring so many PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/engineering Scope related to toolchain, workflow, workspace, and CI/CD, deploy, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants