refactor(stage-ui): use public package exports - #2373
Conversation
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e46cf2a2b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5bad29278
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e5bad29 to
f0f9552
Compare
|
Thanks! I miss you so much, thanks for refactoring so many PRs. |
Description
@proj-airi/stage-uibypassed two public package boundaries:Stage.vueimporteduseSettingsLive2dfrom thestage-ui-live2dsource tree.useLocalStorageManualResetfrom thestage-sharedsource tree.This PR replaces both source-tree imports with their existing public package entries:
@proj-airi/stage-ui-live2d@proj-airi/stage-shared/composablesThis keeps package consumers independent from another package's internal file layout.
Linked Issues
None.
Additional Context
There is no runtime or visual behavior change.
Verification:
sem diff --staged --no-cosmetics -v --file-exts .ts .tsxsem diff --staged --no-cosmetics -v --file-exts .vuepnpm -F @proj-airi/stage-ui typecheckpnpm lint— 0 errors and 7 existing warnings outside this changegit diff --checkThe full workspace
pnpm typecheckwas also run. In the isolated worktree it stopped in unchangedelectron-vueusebecause the generatedelectron-eventaoutput was not present. The affected package type check above passed.