-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Windows CUDA llama.cpp release asset #3248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
53d9635
b3ab118
f0b08bc
1b9f41c
1e1916c
3fa3456
388c687
cc45f4c
6e40bea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,31 @@ | ||||||||||||||||||||||||||||
| from pathlib import Path | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| ROOT = Path(__file__).resolve().parents[3] | ||||||||||||||||||||||||||||
| WORKFLOW = ROOT / ".github" / "workflows" / "build-llamacpp-binaries.yml" | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| def test_windows_cuda_release_asset_is_in_matrix(): | ||||||||||||||||||||||||||||
| workflow = WORKFLOW.read_text(encoding="utf-8") | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| assert "name: windows-x64-cuda" in workflow | ||||||||||||||||||||||||||||
| assert "cuda: true" in workflow | ||||||||||||||||||||||||||||
| assert "windows-x64-cuda" in workflow | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| def test_windows_cuda_build_uses_cuda_toolkit_and_flags(): | ||||||||||||||||||||||||||||
| workflow = WORKFLOW.read_text(encoding="utf-8") | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| assert "Jimver/cuda-toolkit@v0.2.35" in workflow | ||||||||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Asserting the exact version of a third-party GitHub Action makes the test brittle and prone to failure when the action is updated in the workflow. Asserting just the action name is more robust.
Suggested change
|
||||||||||||||||||||||||||||
| assert "if: matrix.cuda" in workflow | ||||||||||||||||||||||||||||
| assert "-DGGML_CUDA=ON" in workflow | ||||||||||||||||||||||||||||
| assert "-DGGML_CUDA_FA=OFF" in workflow | ||||||||||||||||||||||||||||
| assert "-DGGML_CUDA_NCCL=OFF" in workflow | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| def test_release_notes_explain_cpu_and_cuda_windows_assets(): | ||||||||||||||||||||||||||||
| workflow = WORKFLOW.read_text(encoding="utf-8") | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| assert "windows-x64-cuda" in workflow | ||||||||||||||||||||||||||||
| assert "--backend cuda" in workflow | ||||||||||||||||||||||||||||
| assert "Windows CUDA" in workflow | ||||||||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test reads the GitHub Actions workflow file (
Suggested change
|
||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA 13.2 is not an existing CUDA version (the current major version is 12). This should be updated to the actual CUDA version configured in the workflow (e.g., 12.x or 12.2/12.3) to avoid user confusion.