Isolate mainExecutableFile error to runAfter#20
Open
stretchkennedy wants to merge 3 commits into
Open
Conversation
The CustomAction LaunchedInstalledExe refers to a FileKey for a non-existent file, mainExecutableFile. Since it's only necessary for supporting --run-after, this commit stops it being defined unless runAfter is truthy. This is not a fix for the underlying issue! However, it isolates the problem to users of --run-after, which has other bugs that make it hard to test, so it's a good interim fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CustomAction LaunchedInstalledExe refers to a FileKey for a non-existent file, mainExecutableFile. Since it's only necessary for supporting --run-after, this commit stops it being defined unless runAfter is truthy.
This is not a fix for the underlying issue! However, it isolates the problem to users of --run-after, which has other bugs that make it hard to test, so it's a good interim fix.
Also fixes some whitespace formatting that mixed tabs and spaces.
See #19 for more details.