fastVoteR 0.0.3 update#158
Merged
Merged
Conversation
bblodfon
commented
May 16, 2026
be-marc
reviewed
May 21, 2026
| private$.result = private$.result[keep] | ||
| private$.stability_global = NULL | ||
| private$.stability_learner = NULL | ||
| print(sprintf("%s results with zero selected features have been removed.", n_removed)) |
|
|
||
| # remove zero features (all rows with the featureless learner should be removed) | ||
| efsr_zero = efsr$clone(deep = TRUE) | ||
| suppressMessages(efsr_zero$rm_zero_features()) |
Member
There was a problem hiding this comment.
This will not work on print(...). You can remove this when print() is replaced with lg$info(...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change was that I dropped the
data.tabledependency infastVoteR, and I just convert the returneddata.frameto adata.tableinmlr3fselect, according tomlr3conventions