Skip to content

Expose SQL Types in Cursor#621

Open
celestialorb wants to merge 5 commits into
mkleehammer:masterfrom
ccpgames:expose-sql-types
Open

Expose SQL Types in Cursor#621
celestialorb wants to merge 5 commits into
mkleehammer:masterfrom
ccpgames:expose-sql-types

Conversation

@celestialorb

Copy link
Copy Markdown

This is a follow-up PR for issue #167, which has had a PR submitted already (#168). When testing this modified pyodbc package locally I found that the coldescription attribute of the cursor was not set properly for procedures that return more than one result set.

@mkleehammer

Copy link
Copy Markdown
Owner

Very nice and clean.

I know it seems analogous to Cursor.description, but I am concerned about adding any more processing for something that will be rarely used. When needed it is important, but I think it won't be needed most of the time. What do you think about turning it into a function instead?

It might also be nice to figure out if we can easily make the return type a list of namedtuples. Then we could document that attributes may be added to the tuple in the future, so use the names instead of tuple unpacking.

@mkleehammer

Copy link
Copy Markdown
Owner

I've put this on hold for v5 due to the suggestions I made above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants