Use SQL_NUMERIC_STRUCT by default for DECIMAL/NUMERIC values#1470
Merged
Conversation
This avoids problems caused by incorrect guesses about what character is used for the decimal separator when the values are returned as strings. A new connection property (fetch_decimal_as_string) is added for overriding the new default behavior. Also fixed a bug in the fallback function DecimalFromText(), which was missing an argument in a Python API call. Fixes mkleehammer#753
bkline
force-pushed
the
753-binary-decimal
branch
from
April 20, 2026 15:21
a99c3d7 to
90c5999
Compare
# Conflicts: # src/connection.cpp # src/pyodbc.pyi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids problems caused by incorrect guesses about what character is used for the decimal separator when the values are returned as strings.
A new connection property (fetch_decimal_as_string) is added for overriding the new default behavior.
Also fixed a bug in the fallback function DecimalFromText(), which was missing an argument in a Python API call.
Fixes #753