Try-catch os.popen() for command failures - #1214
Open
RA80533 wants to merge 1 commit into
Open
Conversation
bkline
reviewed
Apr 20, 2026
| try: | ||
| cflags, ldflags = pipe.readlines() | ||
| except ValueError: # The command failed | ||
| cflags, ldflags = '', '' |
Contributor
There was a problem hiding this comment.
I assume the patch is setting cflags and ldflags to empty strings in the except block because you want to guard against another exception in the case in which we end up in the exit_status is None block. Presumably that would happen if odbc_config was found but produced malformed output for some reason. In that case wouldn't it be preferable to at least warn the user about the problem, if not abort the script altogether with an appropriate error message? You could set cflags and ldflags to None and then test them in the if exit_status is None` block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1213