fix: Logs in light terminal themes - #91
Conversation
| // I really didn't want to have to fork this package, but it breaks | ||
| // compatibility with light terminal themes by forcing the message to be | ||
| // printed with a while color. | ||
| // No other slog handlers seem to do JSON printing of the attributes. |
There was a problem hiding this comment.
Wow, that sounds like something that could also go upstream? Plenty of terminals ship in white by default, Apple's, iTerm 2, Konsole with Plasma's default look, I'm surprised no one submitted something like that to the upstream project yet. Also, respecting NO_COLOR would be neat, I don't think it does that?
There was a problem hiding this comment.
Couldn't hurt, but I also noticed the lightGray didn't work in a lot of themes either (in Ghostty at least) so I changed those too, most of the colours used actually. But an issue upstream that setting the message to white breaks light themes couldn't hurt.
The NO_COLOR / tty detection stuff actually needs to be done downstream in projects, as that's something turned on manually.
🤖 I have created a release *beep* *boop* --- ## [0.9.1](v0.9.0...v0.9.1) (2026-07-16) ### Bug Fixes * **doc:** fix inconsistent between doc and impl ([#88](#88)) ([55ac767](55ac767)) * Logs in light terminal themes ([#91](#91)) ([c762346](c762346)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
Fixes #90
Preview