feat: Determine server info - #51
Closed
mikew wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of what's holding back Windows report support is that nvrh assumes a bash/unix like environment.
Most of it isn't so bad, it expects
/tmpto exist, but the main command to start the remote neovim instance relies on a fairly bash-compatiable shell, since it uses$SHELL -i -c '...'This PR adds some groundwork for determining some server info (namely the shell and temp directory), but it's a chicken an egg problem, since it relies on starting the remote neovim instance before it can begin doing that.
I think there's maybe some path forward where we can just run
nvim -u NONE --headless -listen :SOME_PORT-u NONEbecause we're just going to run some luaBut this expects
nvimto exist in the usersPATH, which is why I've been using$SHELL -ibecause ... guess who has two thumbs andnvimisn't in myPATHuntil fully loading an interactive shell ...