Connect to Workspace Supports Tenant ID Resource Identifier#3303
Open
ScottCarda-MS wants to merge 5 commits into
Open
Connect to Workspace Supports Tenant ID Resource Identifier#3303ScottCarda-MS wants to merge 5 commits into
ScottCarda-MS wants to merge 5 commits into
Conversation
ScottCarda-MS
changed the title
ScottCarda-MS
requested review from
billti,
idavis and
minestarks
as code owners
amcasey
reviewed
Jun 10, 2026
amcasey
left a comment
amcasey
left a comment
Member
There was a problem hiding this comment.
Seems sensible. Minor suggestions
billti
reviewed
Jun 11, 2026
| // cancelled (e.g. the account is not a member of the tenant, or consent | ||
| // was denied). Without this branch the failure would surface only as a | ||
| // generic message, appearing to fail silently to the user. | ||
| errorText = `Authentication failed. Unable to sign in to ${workspaceDescription}. Please verify the account has access to this workspace and try again.`; |
Member
There was a problem hiding this comment.
I'm finding this all a bit convoluted to follow now, and I'm not sure I understand how the various use-cases interact with this code. Let's discuss and clarify (and maybe put in comments for posterity).
Contributor
Author
There was a problem hiding this comment.
The tenant id and the api key handling have been separated, so hopefully that brings some clarity and cleanliness to the code that you are looking for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the ability of the Connect to Workspace feature to be able to consume resource identification strings containing tenant ids, in addition to being able to consume connection strings with API keys. When connecting to a resource with a resource identification string, the user will be authenticated with Entra ID.