Change mechanism for override in RCA for Length, handle Length calls and Range types in Partial Eval#3286
Open
swernli wants to merge 4 commits into
Open
Change mechanism for override in RCA for Length, handle Length calls and Range types in Partial Eval#3286swernli wants to merge 4 commits into
Length, handle Length calls and Range types in Partial Eval#3286swernli wants to merge 4 commits into
Conversation
…d `Range` types in Partial Eval This change removes the special override for `Length` that was used in RCA, processing it using the regular inferred characteristics. This means that it may show up as "Dynamic Constant" expression, so Partial Eval now needs to handle those calls to `Length` directly rather than assuming they will be handed off to the underlying full evaluator. Likewise, this now allows for "Dynamic Constant" `Range` values, which Partial Eval can handle appropriately. To fix the handling of loops based on these constant values, we now correctly emit the loop only if the loop condition is a "Dynamic Variable" value, rather than on any non-"Static" value. Fixes #3281 Fixes #3282
swernli
changed the title
Length, handle Length calls and Range types in Partial EvalLength, handle Length calls and Range types in Partial Eval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: approach updated after introduction of monomorphization pass.
This change removes the overrider module in RCA that was only used for
Length(holdover from a previous approach and still required some special handling later in analysis). Instead, the initial override and RCA override for the entire call expression is changed to use a single check that recognize theLengthintrinsic and any monomorphized copies of it to ensure it gets a normalApplicationGeneratorSetand call sites are treated the same as any other function. This means that it may show up as "Dynamic Constant" expression, so Partial Eval now needs to handle those calls toLengthdirectly rather than assuming they will be handed off to the underlying full evaluator. Likewise, this now allows for "Dynamic Constant"Rangevalues, which Partial Eval can handle appropriately. To fix the handling of loops based on these constant values, we now correctly emit the loop only if the loop condition is a "Dynamic Variable" value, rather than on any non-"Static" value.Fixes #3281 Fixes #3282