libvirt: build CH installer refs from source#4493
Open
vyadavmsft wants to merge 1 commit into
Open
Conversation
When cloudhypervisor_installer_ref overrides a binary Cloud Hypervisor installer ref, force installation so LISA does not keep an already-installed binary for the wrong ref. Keep release-tag refs on the existing binary download path. For non-release refs, require the MS source-build variables use_ms_clh_repo=yes, ms_access_token, ms_clh_repo, and ms_igvm_repo, then switch the installer to ms_clh_source. This avoids silently falling back to a hardcoded upstream GitHub repo or an embedded internal IGVM repo URL. Add the source-build packages needed by Cloud Hypervisor builds, including make on Ubuntu and Azure Linux plus perl/perl-FindBin on Azure Linux. Tests: isort --check-only, black --check, and flake8 on lisa/sut_orchestrator/libvirt/transformers.py. MyPy still reports existing imported dependency/repo diagnostics outside this change.
🤖 AI Test SelectionNo test cases were selected for this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the libvirt Cloud Hypervisor installer transformer logic so that when cloudhypervisor_installer_ref points to a non-release ref, LISA won’t try to reuse/download a release-binary path; instead it requires MS source-build variables and switches to the MS source installer, forcing installation to avoid keeping an already-installed binary for a different ref.
Changes:
- Detect Cloud Hypervisor “release tag” refs (e.g.
v40.0) vs non-release refs via a regex helper and keep release tags on the binary-download path. - When a non-release ref is provided for a binary installer, require
use_ms_clh_repo=yesplusms_access_token,ms_clh_repo,ms_igvm_repo, then switch installer type toms_clh_source. - Add missing build dependencies for source builds (
makeon Ubuntu/Azure Linux;perl+perl-FindBinon Azure Linux).
LiliDeng
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cloudhypervisor_installer_ref overrides a binary Cloud Hypervisor installer ref, force installation so LISA does not keep an already-installed binary for the wrong ref.
Keep release-tag refs on the existing binary download path. For non-release refs, require the MS source-build variables use_ms_clh_repo=yes, ms_access_token, ms_clh_repo, and ms_igvm_repo, then switch the installer to ms_clh_source. This avoids silently falling back to a hardcoded upstream GitHub repo or an embedded internal IGVM repo URL.
Add the source-build packages needed by Cloud Hypervisor builds, including make on Ubuntu and Azure Linux plus perl/perl-FindBin on Azure Linux.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results