Skip to content

Fail smoke test on reboot errors #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vyadavmsft wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

Fail smoke test on reboot errors #4472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8734342
Fail smoke test on reboot errors
vyadavmsft May 10, 2026
aa2275e
Update reboot failure comment and message in provisioning smoke test
Copilot May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lisa/microsoft/testsuites/core/provisioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,10 +592,12 @@ def _smoke_test(
saved_path=log_path, stage="reboot", force_run=True
)

# if node cannot be connected after reboot, it should be failed.
if isinstance(e, TcpConnectionException):
raise BadEnvironmentStateException(f"after reboot, {e}")
raise PassedException(e)
# any reboot error should fail and mark the environment as bad.
raise BadEnvironmentStateException(
f"reboot failed on node '{node.name}': {e}. "
f"Check serial console logs under '{log_path}' and verify the node is "
"reachable."
) from e
return timer.elapsed()

def is_mana_device_discovered(self, node: RemoteNode) -> bool:
Expand Down
Loading