Skip to content

Fix for regression in modprobe script run #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanchansenlaskar wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

Fix for regression in modprobe script run #4453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions lisa/tools/modprobe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from typing import Any, Dict, List, Optional, Type, Union

from lisa.executable import CustomScript, CustomScriptBuilder, ExecutableResult, Tool
from lisa.tools import Cat, Chown, Dhclient
from lisa.tools import Cat, Dhclient
from lisa.tools.dmesg import Dmesg
Comment on lines 10 to 12
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description template is still blank (no filled-in Description/Related Issue/Test Validation). Please add a short description of what regression is being fixed and include test results or a rationale for not running tests.

Copilot uses AI. Check for mistakes.
from lisa.tools.journalctl import Journalctl
from lisa.tools.kernel_config import KLDStat
Expand Down Expand Up @@ -207,20 +207,16 @@ def reload(
include_output=True,
)

original_user = self.node.tools[Whoami].get_username()
if original_user:
self.node.tools[Chown].change_owner(
file=Path(loop_process_pid_file_name), user=original_user
)

cat = self.node.tools[Cat]
tried_times: int = 0
timer = create_timer()
# Wait for the loop process to start and check its status
while (timer.elapsed(False) < timeout) or tried_times < 1:
tried_times += 1
try:
pid = cat.read(loop_process_pid_file_name, force_run=True)
pid = cat.read(
loop_process_pid_file_name, force_run=True, sudo=True
).strip()
Comment thread
LiliDeng marked this conversation as resolved.
Comment thread
LiliDeng marked this conversation as resolved.
r = self.node.execute(
f"ps -p {pid} > /dev/null && echo 'running' || echo 'not_running'",
sudo=True,
Expand Down
Loading