Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Add ability to move selected item on top (fixes #683)#684

Open
goggle wants to merge 1 commit into
michael-lazar:masterfrom
goggle:focus
Open

Add ability to move selected item on top (fixes #683)#684
goggle wants to merge 1 commit into
michael-lazar:masterfrom
goggle:focus

Conversation

@goggle

@goggle goggle commented Apr 28, 2019

Copy link
Copy Markdown

As described in #683 this PR adds a new navigation feature to RTV, that allows to move the currently selected item on top of the visible window.

@michael-lazar

Copy link
Copy Markdown
Owner

Thanks for the PR (and test!). I want to sit on it for a little while to ponder about the key binding, but overall your code additions look pretty clean and straightforward.

@goggle

goggle commented Apr 29, 2019

Copy link
Copy Markdown
Author

Yes, I wasn't sure about the key binding either. It would be nice if it is something on the right side of the keyboard, since the other navigation keys are also on the right side.
There might also be a better name than focus_up.

@jparkrr

jparkrr commented May 15, 2019

Copy link
Copy Markdown

This is a dope feature. Don't know about the keybinding, but would love to see it merged.

@goggle

goggle commented May 15, 2019

Copy link
Copy Markdown
Author

Yeah, on a Swiss QWERTZ keyboard to - key is really convenient to use for this, but probably not on an American QWERTY keyboard. I think the corresponding key on an American keyboard would be /. But this key is already reserved for the prompt.

Maybe the zero key 0 would be a good alternative?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants