This repository was archived by the owner on Feb 20, 2023. It is now read-only.
Add support for best/ being the new default sort#619
Open
amigan wants to merge 1 commit into
Open
Conversation
amigan
changed the title
Owner
|
Thanks for the PR! Overall the changes look pretty straightforward and I will try to get around to cleaning this up a bit and merging soon. The praw changes will need to be merged into my fork @ https://github.com/michael-lazar/praw3 |
|
any updates on this? |
Owner
|
Sorry, I have been busy focusing on other endeavors and haven't gotten around to it yet. Thanks for the bump though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is super quick and dirty and I haven't written any tests.