Skip to content

fix: log removeDevice failures during removeConnection #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danditomaso wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: log removeDevice failures during removeConnection #1283

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f56b0
fix(useConnections): log removeDevice failures instead of swallowing
danditomaso Jul 12, 2026
0ac87e4
Merge branch 'main' into fix/log-remove-connection-errors
danditomaso Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions apps/web/src/pages/Connections/useConnections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,13 @@ export function useConnections() {
if (conn?.meshDeviceId) {
try {
useDeviceStore.getState().removeDevice(conn.meshDeviceId);
} catch {}
} catch (err) {
log.warn("removeDevice failed during removeConnection", {
id,
meshDeviceId: conn.meshDeviceId,
err,
});
}
Comment on lines +91 to +97
}
meshRegistry.unregister(id);
removeSavedConnectionFromStore(id);
Expand Down Expand Up @@ -249,7 +255,9 @@ export function useConnections() {
// Read from the live store, not the memoized `connections` closure: callers
// such as addConnectionAndConnect() add a connection and connect to it in the
// same tick, before this hook re-renders, so the closure would be stale.
const conn = useDeviceStore.getState().savedConnections.find((c) => c.id === id);
const conn = useDeviceStore
.getState()
.savedConnections.find((c) => c.id === id);
if (!conn) {
log.warn("connect: unknown connection id", { id });
return false;
Expand Down
Loading