Skip to content

Nz sf region#985

Open
NomDeTom wants to merge 5 commits into
meshtastic:masterfrom
NomDeTom:nz-sf-region
Open

Nz sf region#985
NomDeTom wants to merge 5 commits into
meshtastic:masterfrom
NomDeTom:nz-sf-region

Conversation

@NomDeTom

@NomDeTom NomDeTom commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Adds a new region specifically for New Zealand to allow the ShortFast preset generally in use there to be the "default" from the start. ANZ is still available for legacy users.

Checklist before merging

  • All top level messages commented
  • All enum members have unique descriptions

Summary by CodeRabbit

  • New Features
    • Added support for the NZ_924 LoRa region option, allowing devices to be configured for this regional frequency band.

claude and others added 3 commits July 11, 2026 08:24
Adds a new RegionCode enum value NZ_SF = 38 that uses the same
frequency band as ANZ, intended for the Short Fast modem preset.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016CZ7bDuPL67jJS1D7RV9oB
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016CZ7bDuPL67jJS1D7RV9oB
@CLAassistant

CLAassistant commented Jul 14, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@NomDeTom, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2acb702e-a8c8-4138-ac14-ac0bc1e13194

📥 Commits

Reviewing files that changed from the base of the PR and between 341b5af and 1153d23.

📒 Files selected for processing (2)
  • meshtastic/config.proto
  • meshtastic/mesh.options
📝 Walkthrough

Walkthrough

Adds the NZ_924 = 38 region value to the LoRaConfig.RegionCode enum in meshtastic/config.proto.

Changes

LoRa region support

Layer / File(s) Summary
Add NZ_924 region code
meshtastic/config.proto
Adds and documents NZ_924 = 38 after ITU2_125CM = 37 in the RegionCode enum.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: thebentern, jp-bennett

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and refers to the new New Zealand region added by this change.
Description check ✅ Passed The description explains the New Zealand region addition and includes the checklist, though the related issue link is omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@meshtastic/config.proto`:
- Around line 993-998: Increase the max_count for
LoRaRegionPresetMap.region_groups in mesh.options from 38 to 39 to accommodate
RegionCode.NZ_924, then regenerate the protobuf bindings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 489e2958-1f85-4bc1-be6d-625d60b197a4

📥 Commits

Reviewing files that changed from the base of the PR and between da2fc41 and 341b5af.

📒 Files selected for processing (1)
  • meshtastic/config.proto

Comment thread meshtastic/config.proto Outdated
@coderabbitai coderabbitai Bot mentioned this pull request Jul 19, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants