Skip to content

Fix direct repeater login timeout#2997

Open
axhoff wants to merge 1 commit into
meshcore-dev:devfrom
axhoff:agent/fix-direct-login-timeout
Open

Fix direct repeater login timeout#2997
axhoff wants to merge 1 commit into
meshcore-dev:devfrom
axhoff:agent/fix-direct-login-timeout

Conversation

@axhoff

@axhoff axhoff commented Jul 20, 2026

Copy link
Copy Markdown

Summary

  • account for the flood-routed response to a direct repeater login
  • keep the existing direct timeout for rooms and other contact types
  • choose the larger end-to-end estimate instead of stacking two round-trip budgets
  • add focused regression coverage for the timeout selection

Why

Repeater login requests do not carry a return path. Even when the request uses a known direct path, the repeater deliberately sends its login response by flood. The companion radio previously advertised only the direct-route timeout to the app, so a valid response could arrive after the app had already timed out.

This keeps the known path for the outbound request and only adjusts the timeout budget for the asymmetric direct-outbound/flood-return exchange.

Fixes #2955

Validation

  • pio test -e native (16 tests passed)
  • pio run -e Xiao_S3_companion_radio_usb
  • git diff --check

@axhoff
axhoff marked this pull request as ready for review July 20, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant