Fix blank guest room authorization#2995
Open
axhoff wants to merge 2 commits into
Open
Conversation
axhoff
marked this pull request as ready for review
July 20, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The room server compared the supplied password with configured role passwords before applying
allow.read.only. When both strings were empty,strcmp()succeeded and promoted an anonymous user instead of treating the empty configured password as a disabled authenticated role.Empty admin and guest passwords now disable their corresponding authenticated roles. With
allow.read.onlyenabled, a blank or incorrect password receives the existing guest permission; with it disabled, the login is rejected.Compatibility
Validation
pio test -e native: 21/21 tests passedpio run -e Heltec_v3_room_server: passed (ESP32)pio run -e RAK_4631_room_server: passed (nRF52)pio run -e PicoW_room_server: passed (RP2040)Fixes #940