Fix: Semtech radio Sleep fails when not in Standby#2986
Open
entr0p1 wants to merge 1 commit into
Open
Conversation
… SX1268, LLCC68, possibly also LR1110 and LR1121). From Semtech datasheet for SX1262, SX1268, LLCC68: "The command SetSleep(...) sets the device in SLEEP mode with the lowest current consumption possible. This command can be sent only while in STDBY mode " SX1276 not affected, LR1110 and LR1121 are unclear from the datasheets. Fixes: - RadioLibWrapper, CustomSX1262Wrapper: call Standby() before calling Sleep() as
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Radio powerOff() may be ineffective on some radios (confirmed SX1262, SX1268, LLCC68, possibly also LR1110 and LR1121) if the radio is not in Standby state (e.g. if its in RX). This PR ensures the radio is in standby before calling the sleep command.
From section 13.1.1 of Semtech datasheet for SX1262, SX1268, LLCC68: "The command SetSleep(...) sets the device in SLEEP mode with the lowest current consumption possible. This command can be sent only while in STDBY mode "
SX1262 Datasheet
SX1268 Datasheet
LLCC68 Datasheet
SX1276 not affected, LR1110 and LR1121 are unclear from the datasheets.
Fixes: