Added notes to the README#6
Open
einraz wants to merge 4 commits into
Open
Conversation
… to the webhook command.
… it will run on Openshift without additional issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to deploy this to OpenShift and was repeatedly having issues with binding to port 443. I realized that an argument needed to be passed to the webhook command on entry to switch the default port, as well as the container port changed to match. I tested this and it works with cert-manager successfully. Feel free to edit this in any way you see fit, I just thought people would be able to benefit from this additional information.