Merge changes from upstream webhook-example.#2
Open
oursland wants to merge 19 commits into
Open
Conversation
A few resources didn't specify a namespace, resulting in a discrepency if `helm template --namespace` is ran and later `kubectl apply` is in a different context. Signed-off-by: James Lakin <james@jameslakin.co.uk>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Update to small logo
This includes switching to go 1.17. Signed-off-by: Marko Vukovic <anonsoftware@gmail.com>
Kubebuilder tools version 1.21.2 previously used does not work on arm64 (specifically Raspberry PI). Interestingly, the latest (as of the time of this commit) version 1.24.2 does not work either. An error message like this causes the test to fail: apiserver.go:43: failed to start control plane: unable to start control plane itself: failed to start the controlplane. retried 5 times: timeout waiting for process kube-apiserver to start However, with 1.24.1 the test "mostly" passes, although it may occasionally fail. It might be that Raspberry PI is too slow and something times out. Signed-off-by: Marko Vukovic <anonsoftware@gmail.com>
Signed-off-by: Marko Vukovic <anonsoftware@gmail.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Add Tim to OWNERS file
…space Add explicit namespaces to all namespaced resources in Helm charts
Signed-off-by: irbekrm <irbekrm@gmail.com>
Also removes a bunch of replaces that should no longer be needed Signed-off-by: irbekrm <irbekrm@gmail.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
|
@mdonoughe any objections? EDIT: It seems cert-manager upstream has removed kubebuilder. In order for tests to run (and pass), it suffices on my end to remove line 26 of |
Owner
|
This PR makes a lot of changes and I don't understand what it's supposed to do. |
|
Each of these changes are taken from the upstream example. Either tidying up existing code or changing existing functionality for compatibility with newer versions of cert-manager. It is essentially a merge of the upstream with your repository. I have taken the changes in this PR and made a minor change to the conformance test. This allows me to use this webhook with the latest cert-manager and Porkbun API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.