Ff154 css typed OM cleanup - #44945
Merged
Merged
Conversation
hamishwillee
requested review from
dipikabh and
sideshowbarker
and removed request for
a team
July 28, 2026 08:04
github-actions
Bot
added
Content:WebAPI
Contributor
8 tasks
dipikabh
approved these changes
Jul 30, 2026
dipikabh
left a comment
dipikabh
left a comment
Contributor
There was a problem hiding this comment.
Thanks, Hamish! Your updates look good overall.
I've added minor edit suggestions, mostly around adding/removing commas, "that" vs. "which"...tidying up as we go since you're already touching these lines to fix the line breaks.
And there's also a few specific comments in CSSStyleValue.toString().
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
Author
|
Thanks for the review @dipikabh ! Agree a good opportunity to fix these up - and I'm glad you did it because your grammar is better than mine. I've also tidied up Much appreciated. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF154 adds preview support for the CSS Typed OM API. This is an initial fix to the docs in preparation for more thorough docs afterwards.
The fixes are done three commits.
CSSStyleValue.toString()- that's the only strict content addition.Basic usageheading for examples. That can be treated more or less as a layout only review.There is a lot more to do. The entry point for the API doc is out of date, and so on. Many of the docs have "to do" in examples. This is just to get the basics ready for a more thorough look.
Related docs can be tracked in #44849