Skip to content

do not create target directory if root directory #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superigno wants to merge 3 commits into
base: master
Choose a base branch
from
Open

do not create target directory if root directory #113

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9378a85
do not create target directory if root directory
Nov 30, 2020
e7988ef
Update index.js
superigno Nov 30, 2020
f64884c
Update index.js
superigno Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ class Extractor {
const destDir = path.dirname(path.join(this.opts.dir, entry.fileName))

try {
await fs.mkdir(destDir, { recursive: true })
if (!path.parse(process.cwd()).root === destDir) {
Comment thread
superigno marked this conversation as resolved.
Outdated
await fs.mkdir(destDir, { recursive: true })
}

const canonicalDestDir = await fs.realpath(destDir)
const relativeDestDir = path.relative(this.opts.dir, canonicalDestDir)
Expand Down Expand Up @@ -167,7 +169,10 @@ module.exports = async function (zipPath, opts) {
throw new Error('Target directory is expected to be absolute')
}

await fs.mkdir(opts.dir, { recursive: true })
if (!path.parse(process.cwd()).root === opts.dir) {
Comment thread
superigno marked this conversation as resolved.
Outdated
await fs.mkdir(opts.dir, { recursive: true })
}

opts.dir = await fs.realpath(opts.dir)
return new Extractor(zipPath, opts).extract()
}