Add assert to check payload length during codegen - #381
Merged
Conversation
pv42
force-pushed
the
panic_payload_len
branch
from
August 22, 2025 11:50
51a1d25 to
8c794d9
Compare
joaoantoniocardoso
approved these changes
Aug 22, 2025
onur-ozkan
self-requested a review
August 22, 2025 18:42
onur-ozkan
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both MAVLink versions only support up to 255 payload bytes.
Currently the codegenerator will happily generate messages with any
usizelength. Such messages will cause panics when attempting to de-/serialize them.This PR adds an assert to prevent such cases.
Note: It seems to be theoretically possbile to have a message definition over 255 bytes fit into a 255 payload with truncated zeros, but I cant see a usecase arise from this since everything past byte 255 would always need to be 0.