mavlink-bindgen: skip non XML files - #353
Merged
Merged
Conversation
onur-ozkan
reviewed
Jul 28, 2025
azerupi
force-pushed
the
master
branch
2 times, most recently
from
July 29, 2025 09:24
f0f76b4 to
cefd987
Compare
onur-ozkan
reviewed
Jul 29, 2025
onur-ozkan
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running mavlink-bindgen in a directory that contains other files it fails. In my case it panicked when trying to "generate" bindings for
.git.Example directory
This PR adds a check when iterating over the entries in the directory to skip hidden files, directories and non-XML files.