Conversation
Make all log lines start with a capital letter for consistency. Where a line begins with a bare identifier (syscall, function, message or field name), prepend a descriptive word instead of capitalizing the identifier itself, e.g. "getaddrinfo failed" -> "Call getaddrinfo failed".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes all log lines in the library start with a capital letter for consistency (following the
Heartbeats from system ... timed outfix).Where a line began with a bare identifier — a syscall, function, message, or field name — I prepended a descriptive word rather than capitalizing the identifier itself, so the token stays intact:
"getaddrinfo failed"→"Call getaddrinfo failed"(alsotcgetattr,cfsetispeed,fs::exists,tinyxml2::LoadFile, ...)"mission_request_int: ..."→"In mission_request_int: ...""metadataTypes not found"→"Field metadataTypes not found""current_metadata_path() called ..."→"Function current_metadata_path() ..."Plain-English messages were simply capitalized (
"command denied"→"Command denied","version not found"→"Version not found", etc.).Notes
Log*(...)lines remain insrc/mavsdk.