Ignore Content-Type parameters when polling MSC4108 rendezvous channel - #5404
Draft
krithin wants to merge 1 commit into
Draft
Ignore Content-Type parameters when polling MSC4108 rendezvous channel#5404krithin wants to merge 1 commit into
krithin wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Z-Community-PR
MSC4108RendezvousSession.receive() compared the Content-Type header against "text/plain" with strict string equality. If a reverse proxy in front of the rendezvous server appends parameters to the header (e.g. nginx's `charset` directive rewrites it to `text/plain; charset=utf-8`), every incoming payload was treated as "no new message" and silently discarded, deadlocking QR code login until the session expired. Parse out the media type per RFC 9110 (parameters follow the type/subtype after a semicolon; type names are case-insensitive) before comparing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Krithin Sitaram <1389679+krithin@users.noreply.github.com>
krithin
force-pushed
the
fix/msc4108-rendezvous-content-type-params
branch
from
July 8, 2026 07:08
43d5516 to
53ffe26
Compare
Member
|
Unfortunately the spec dictates This is the v2024 edition of MSC4108 which is the only variant currently supported. The v2025 (latest) edition of the MSC does not have this issue seemingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSC4108RendezvousSession.receive() compared the Content-Type header against "text/plain" with strict string equality. If a reverse proxy in front of the rendezvous server appends parameters to the header (e.g. nginx's
charsetdirective rewrites it totext/plain; charset=utf-8), every incoming payload was treated as "no new message" and silently discarded, deadlocking QR code login until the session expired.Parse out the media type per RFC 9110 (parameters follow the type/subtype after a semicolon; type names are case-insensitive) before comparing.
Checklist
public/exportedsymbols have accurate TSDoc documentation.