Move alt text editor to a separate view controller - #864
Draft
j-f1 wants to merge 6 commits into
Draft
Conversation
1 task
|
#813 is a bug that this suggestion would address. This is a critical bug. It prevents people from adding alt text to images that visually-impaired people depend upon. If you can, it may be good to put "Accessibility Bug" in the title. |
1 task
|
I just noticed that if you add more than one image, it is only the last one that you can't scroll and set the alt text. That is because the app doesn't stay at the bottom if you scroll to the bottom. It bounces back to put the alt text overlay below the region that is shown. So, this looks like it may be a problem caused by adding the overlay bouncing back after scrolling to the bottom. That may be something that could be fixed by a simpler fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This definitely needs a design pass on multiple levels but here’s what it looks like right now: