Avoid crash from dangling action pointers in ActionManager#4551
Open
bjorn wants to merge 2 commits into
Open
Conversation
ActionManager stores raw QAction pointers in mIdToActions and only removed them when unregisterAction() was called explicitly. An action destroyed without being unregistered therefore left a dangling pointer behind, which ActionsModel::refreshConflicts() would later dereference (via findAction()), crashing when opening the Preferences dialog. The exact trigger of the reported crashes is unknown. All built-in actions should live until the application exits and scripted actions should already have been calling unregisterAction as appropriate. Tracking destruction of the QAction instance makes the code less fragile and will hopefully avoid this kind of crash. This fixes a crash that was reported on Sentry.
bjorn
force-pushed
the
fix-action-dangling-pointer
branch
from
9153b96 to
84ccb63
Compare
Since it's going to be re-assigned just afterwards anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActionManagerstores rawQActionpointers inmIdToActionsand only removed them whenunregisterAction()was called explicitly. An action destroyed without being unregistered therefore left a dangling pointer behind, whichActionsModel::refreshConflicts()would later dereference (viafindAction()), crashing when opening the Preferences dialog.The exact trigger of the reported crashes is unknown. All built-in actions should live until the application exits and scripted actions should already have been calling
unregisterActionas appropriate. Tracking destruction of theQActioninstance makes the code less fragile and will hopefully avoid this kind of crash.This fixes a crash that was reported on Sentry.