-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New Hardware Renderer: Add tool brush to mapview.qml #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
UltraDagon
wants to merge
29
commits into
mapeditor:new-hardware-renderer
Choose a base branch
from
UltraDagon:nhr/tool-brush
base: new-hardware-renderer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
0b03c73
Created new mapItem instance for rendering the tool brush on mapview.…
UltraDagon 6760a51
Fixed tool brush mapitem to no longer cause errors when the map is un…
UltraDagon f530985
mapview.qml updates upon old editor tool usage
UltraDagon 0005b76
Added sizeChanged and tileSizeChanged notify signals to editablemap
UltraDagon 451055f
Changed libtiledquick/mapitem::repaintRegion to only update the affec…
UltraDagon d703b13
Updated new ToolBrush to work with mouse movement and fill tool
UltraDagon 85dcc28
Moved quick brush changes to onQuickBrushChanged and set up emits in …
UltraDagon 833bbf0
Don't link to the tiledquickplugin
bjorn b07fc43
Changed editablemap's size signals to be sent properly; MapItem now r…
UltraDagon 9ca0d81
Added disconnects for libtiledquick/mapitem's setmap connections
UltraDagon 40055c8
Small fixes for review comments
UltraDagon 2e3f22b
Renamed quickBrushChanged signal to brushMapChanged; Javascript owner…
UltraDagon 8632491
Partially implemented requested brushItem->map() and toolBrushMap cha…
UltraDagon e096b8d
Moved brushChanged logic to a Q_PROPERTY and quickMouseCoordsChanged …
UltraDagon 8c3e48f
Fixed ifdefs for TILEDQUICK_LIB
UltraDagon 4cbb046
Created template classes and setup for regionOverlay
UltraDagon e6ac0b9
Fixed crash that happened upon QML's garbage collection for tileEditP…
UltraDagon 5775da4
Fixed small typo in mapview.qml
UltraDagon 26b461f
Fixed memory leak with setTileEditPreview; brushMapChanged now takes …
UltraDagon fc5b3ec
Removed AbstractTileTool::toolBrush(); Fixed crash caused by closing …
UltraDagon b8afceb
Added RegionOverlay for selected tiles to mapview.qml
UltraDagon 163e803
Linked quick mouse onPress and onRelease events to selectedTool
UltraDagon 40b1776
Moved tileEditRegionChanged code from brushItem to abstractTileTool &…
UltraDagon 5d21d77
Changed brushRegionOverlay to indicate if brush is in or out of map b…
UltraDagon d4a3f4a
Added selectedRegionOverlay; RegionOverlay tweaks
UltraDagon a75bf94
Added EditableMap constructor for using SharedMaps
UltraDagon 4dfaad9
Added safeguard for new EditableMap constructor usage; Small RegionOv…
UltraDagon eee95ff
Fixed crash by only forwarding Quick mouse events to an active tool
bjorn 8dd9411
Added requested changes
UltraDagon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UltraDagon marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.