Skip nonce check when using password grant#1455
Open
jwgmeligmeyling wants to merge 1 commit into
Open
Conversation
|
Would be nice to have a fix to this error if a maintainer can take a look at it. |
Author
|
Did you see #1324 (comment) ? I think thats actually a sensible workaround |
L-X-T
force-pushed
the
master
branch
2 times, most recently
from
e1fc6c5 to
5d10af2
Compare
|
Should we apply the same fix for the type |
L-X-T
force-pushed
the
master
branch
2 times, most recently
from
1421146 to
4dff3c3
Compare
L-X-T
force-pushed
the
master
branch
5 times, most recently
from
581dc7a to
328e014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token responses from a password grant may return an id token, but these will never contain a nonce as there is no way to provide one. Therefore, in this scenario, the nonce validation should be skipped when processing the id token.
Fixes #1324