Improve error log message for nonce error(s)#1349
Open
nickedelenbos wants to merge 1 commit into
Open
Conversation
a54ea92 to
078415b
Compare
e1fc6c5 to
5d10af2
Compare
1421146 to
4dff3c3
Compare
581dc7a to
328e014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently had quite a struggle with implementing oAuth for one of our applications. The (fixed) error message lead us to believe that we did not have any state, while in truth we did have state, but we were storing our nonce in a
MemoryStorageinstead oflocalStorage.This improvement will, I hope, help people that encounter the same issue find their configuration error(s) faster.