Skip to content

feat(HappyHare): Added to gate context menu for complete change-tool operation#2430

Closed
moggieuk wants to merge 2 commits into
mainsail-crew:developfrom
moggieuk:changetool_menu
Closed

feat(HappyHare): Added to gate context menu for complete change-tool operation#2430
moggieuk wants to merge 2 commits into
mainsail-crew:developfrom
moggieuk:changetool_menu

Conversation

@moggieuk

@moggieuk moggieuk commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Description

This PR simply adds an additional action button to the per-gate pop-up menu to request a complete toolchange. This is for convenience and potentially saves the user time with separate UNLOAD / SELECT / LOAD operations.

Related Tickets & Documents

n/a

Mobile & Desktop Screenshots/Recordings

Simple adds the "Change Tool" menu item:
changetool_menu_after

[optional] Are there any post-deployment tasks we need to perform?

n/a

@coderabbitai

coderabbitai Bot commented Feb 8, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Added a new "Change Tool" context-menu button to the MMU unit gate component, exposing a new public mdiAxisArrow icon and adding an English translation key for the button label.

Changes

Cohort / File(s) Summary
MMU Unit Gate UI
src/components/panels/Mmu/MmuUnitGate.vue
Introduced import and public member mdiAxisArrow (from @mdi/js); added a context menu button entry using this.mdiAxisArrow, command 'MMU_CHANGE_TOOL', and label this.$t('Panels.MmuPanel.ButtonChangeTool').
Localization
src/locales/en.json
Added translation key Panels.MmuPanel.ButtonChangeTool with value "Change Tool".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nudged a new button into view,
An axis arrow gleaming true,
MMU tools now hop and swap,
Click once, and watch the options hop! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a 'Change Tool' button to the gate context menu for MMU operations.
Description check ✅ Passed The description clearly explains the purpose of adding the new menu item, provides context about the convenience benefit, and includes a screenshot demonstrating the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/components/panels/Mmu/MmuUnitGate.vue`:
- Around line 104-108: The MMU_CHANGE_TOOL action is sending a GATE= parameter
but should send TOOL=<index>; update the gateCommand method (or add a new
toolCommand helper) used by the MMU_CHANGE_TOOL menu entry so it emits
"MMU_CHANGE_TOOL TOOL=<toolIndex>" instead of "GATE=<...>"; either map the
current gateIndex to the correct tool index before dispatching or implement a
separate method (e.g., sendMmuToolChange) that builds the "MMU_CHANGE_TOOL
TOOL=" payload and use that for the MMU_CHANGE_TOOL command in the menu
definition.

Comment thread src/components/panels/Mmu/MmuUnitGate.vue
@moggieuk moggieuk closed this Feb 11, 2026
@moggieuk

Copy link
Copy Markdown
Contributor Author

Closed and replaced with PR #2437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant