Fix multiversion LOD biome tint sampling position#214
Open
G9third wants to merge 3 commits into
Open
Conversation
G9third
commented
Jul 2, 2026
Author
There was a problem hiding this comment.
Updated to avoid duplicating the RGB333 tint palette per tinted model. The client-position tint fix still stores a per-quad quantized tint index, but all biome-tinted models now point at one shared 512-entry RGB333 palette, making the added palette VRAM fixed at about 2 KB total.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes biome/block tint sampling for Voxy LOD generation by using the actual world position of the LOD sample when asking Minecraft's client BlockColors system for tint colors.
Previously, tinted blocks could use a generic or incorrect position during LOD color generation. This could cause visibly wrong LOD colors in terrain/worldgen mods where biome colors depend on the exact world position, such as Big Globe.
The change is isolated to client rendering/model generation: