Bundle Linux aarch64 natives for RocksDB and LWJGL#193
Open
yourGrand wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #186:
Upstream gates multi-platform
rocksdbjnijar behind-PincludeOtherArchs=trueto keep default jars smaller. This PR bundles linux aarch64 only by default instead. The upstream flag can be ported later for parity if desired.Windows ARM64
Voxy's storage depends on RocksDB JNI, and
rocksdbjni10.2.1 only shipslibrocksdbjni-win64.dll.Upstream work is in progress: facebook/rocksdb#14699 adds
win-arm64support torocksdbjni. Once that lands and is published, we can bundlelibrocksdbjni-win-arm64.dlland add LWJGLnatives-windows-arm64in a follow-up.