Fix Immersive portals Crashing and shaders With it#191
Open
DigitalWolf1313 wants to merge 2 commits into
Open
Conversation
DigitalWolf1313
changed the title
Owner
|
wasnt there some evil mem leak that you just ignored 😭 i remember looking at the code before |
Author
|
I Fixed it 🎉 |
Owner
|
oh wonderful |
Author
|
Shall i create a new pull request to point to the multi version branch? |
Owner
|
i can rebase it myself, but the issue is more i have to take the time to see what hacks this uses and what downstream effects it might have (whichll take quite a bit of time) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLAIMER
This is almost 100% Vibecoded with just a few adjustments from me.
This will fix
1: Crashing when rendering a Immersive portal going to another dimension
2: Shaders disabling When viewing a immersive portal
thus closing #21
https://www.youtube.com/watch?v=LDGpcHGKLUQ
(it also works on neoforge)