update assert's type to be more accurate#2556
Draft
nnullcolumn wants to merge 1 commit into
Draft
Conversation
|
|
||
| -- `assert` has a magic function attached that will give more detailed type information | ||
| declare function assert<T>(value: T, errorMessage: string?): T | ||
| declare function assert<T, Err...>(value: T, ...: Err...): (T, Err...) |
Contributor
There was a problem hiding this comment.
The EmbeddedBuiltinDefinitions annotation for assert is effectively unused. In the Old Solver it has a magic type attached, and in the New Solver the definition is overwritten directly here:
luau/Analysis/src/BuiltinDefinitions.cpp
Line 482 in 5e76a0a
This is also the reason for the hover type hint in New Solver
Author
There was a problem hiding this comment.
thanks, sorry for not being more thorough i'll update with tests and better support
nnullcolumn
marked this pull request as draft
July 15, 2026 20:28
Author
|
marking this as a draft for now since it obviously cannot be merged as-is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asserttype signature is incorrect #2538 (duplicate)