partially implement type:setreadindexer#2549
Open
nnullcolumn wants to merge 3 commits into
Open
Conversation
Author
|
whoops broke my own tests by changing an err msg :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, setreadindexer would error with
type.setreadindexer: luau does not yet support separate read/write types for indexers.now that read-only indexers are implemented, this PR suggests a partial implementation locked behind a new flag
LuauUdtfTypeSetReadIndexerMethodand an old oneLuauTypeFunctionTableIndexerIsReadOnlyfor serialization/deserialization. It will error if the table already has a read+write indexer, but otherwise allows the operation. Although partial implementation isn't ideal, some trivially-fixed-once-separate-read-write-indexers-are-implemented dragons are okay as this gets behavior into users' hands sooner and UDTFs are inherently forgiving towards mistakes. As usual, this PR / implementation (although small) is 100% human authored.edit: the existing workaround people are likely to use, provided
LuauTypeFunctionTableIndexerIsReadOnlyis enabled: