stringify false? and ~(false?) to falsy and truthy respectively#2546
Open
nnullcolumn wants to merge 8 commits into
Open
stringify false? and ~(false?) to falsy and truthy respectively#2546nnullcolumn wants to merge 8 commits into
false? and ~(false?) to falsy and truthy respectively#2546nnullcolumn wants to merge 8 commits into
Conversation
Author
|
i have been informed i did not, infact, flag it correctly :p edit: will fix soon, busy w some stuff for now |
Author
|
^ full disclosure, i had an AI agent do the commit updating tests to switch on the fflag everywhere. I went through the diff line by line and everything looks good. It also spotted a mistake, I didn't look closely enough at the cycle detection stuff here and placed the early return for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
soo this is my first time flagging a change, not confident i did that correctly tbh but tests seem to run okay
false?tofalsyand~(false?)totruthyin stringificationmake testtruthyandfalsybuilt-in type aliases #2516