Skip to content

stringify false? and ~(false?) to falsy and truthy respectively#2546

Open
nnullcolumn wants to merge 8 commits into
luau-lang:masterfrom
nnullcolumn:truthy-falsy-stringification
Open

stringify false? and ~(false?) to falsy and truthy respectively#2546
nnullcolumn wants to merge 8 commits into
luau-lang:masterfrom
nnullcolumn:truthy-falsy-stringification

Conversation

@nnullcolumn

Copy link
Copy Markdown

soo this is my first time flagging a change, not confident i did that correctly tbh but tests seem to run okay

@nnullcolumn

nnullcolumn commented Jul 12, 2026

Copy link
Copy Markdown
Author

i have been informed i did not, infact, flag it correctly :p

edit: will fix soon, busy w some stuff for now

@nnullcolumn

nnullcolumn commented Jul 12, 2026

Copy link
Copy Markdown
Author

^ full disclosure, i had an AI agent do the commit updating tests to switch on the fflag everywhere. I went through the diff line by line and everything looks good. It also spotted a mistake, I didn't look closely enough at the cycle detection stuff here and placed the early return for falsy after the check for state.hasSeen, but didn't check if inserting to the seen set was a separate operation (it wasn't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant