VM: Add functions to get/set inline destructors of userdata#2457
Open
Nerixyz wants to merge 2 commits into
Open
VM: Add functions to get/set inline destructors of userdata#2457Nerixyz wants to merge 2 commits into
Nerixyz wants to merge 2 commits into
Conversation
vegorov-rbx
reviewed
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
They get/set the destructor for userdata with an inline destructor (
UTAG_IDTOR). Setting the destructor after the userdata has been created is more important here. The use-case is fallible construction of the userdata:I found this when trying to get the sol2 Lua bindings to work with Luau. There, the userdata is constructed first and the arguments are matched later. In case of overloaded functions, there might not exist an overload, so we'd error out and drop the userdata. We can only set the destructor once we constructed the value inside the userdata.