Skip to content

Fix depth-preserving rewrite - #690

Merged
MyskYko merged 3 commits into
lsils:masterfrom
MyskYko:fix_rw
May 6, 2026
Merged

Fix depth-preserving rewrite#690
MyskYko merged 3 commits into
lsils:masterfrom
MyskYko:fix_rw

Conversation

@MyskYko

@MyskYko MyskYko commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

regarding the issue #687
there was a wrong inequality.
also thinking to clean up code a bit: depth computation is duplicated (depth view already does it) and seemingly incomplete (it only updates two TFO levels for each replacement, which is probably okay for most cases, followed by one TFI level check per iteration, but it might not work when a target node has more than 2 levels of fanouts that are already visited or new, so the follow-up one TFI level check fetches old level).

@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.79%. Comparing base (fa8513a) to head (35a3fe6).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
- Coverage   83.83%   83.79%   -0.04%     
==========================================
  Files         189      189              
  Lines       29888    29034     -854     
==========================================
- Hits        25056    24329     -727     
+ Misses       4832     4705     -127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MyskYko

MyskYko commented May 5, 2026

Copy link
Copy Markdown
Collaborator Author

fixed another bug in level evaluation, where visited nodes now return correct depth rather than 0.

@MyskYko

MyskYko commented May 6, 2026

Copy link
Copy Markdown
Collaborator Author

Will create another PR for cleanup...

@MyskYko
MyskYko merged commit 13b4075 into lsils:master May 6, 2026
18 checks passed
@MyskYko
MyskYko deleted the fix_rw branch May 16, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant