Skip to content

Remove Athena restricted_modules - #81

Merged
bensofficial merged 1 commit into
mainfrom
remove-athena-restricted-modules
Jun 29, 2026
Merged

Remove Athena restricted_modules#81
bensofficial merged 1 commit into
mainfrom
remove-athena-restricted-modules

Conversation

@musaberkay

@musaberkay musaberkay commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the restricted_modules field from the athena configuration block in all group_vars files (production, staging1, staging2, staging_localci, artemistest1-3)
  • Aligns the ansible config with the upstream Artemis change that removed the restricted Athena module feature

Test plan

  • Verify Athena integration still works after deployment (url and secret remain intact)
  • Confirm no Ansible lint errors

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Removed an outdated module restriction setting from several environment configurations.
    • Simplified Athena-related settings so only the connection details remain active.
  • Chores

    • Cleaned up environment-specific configuration entries across production, staging, local CI, and test setups.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@musaberkay
musaberkay requested a review from a team as a code owner June 26, 2026 11:04
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 01f3cd08-66f4-42b8-8f31-a1fd1822d94c

📥 Commits

Reviewing files that changed from the base of the PR and between 4ba8305 and 5b64677.

📒 Files selected for processing (7)
  • group_vars/artemis_production.yml
  • group_vars/artemis_staging1.yml
  • group_vars/artemis_staging2.yml
  • group_vars/artemis_staging_localci.yml
  • group_vars/artemistest1.yml
  • group_vars/artemistest2.yml
  • group_vars/artemistest3.yml
💤 Files with no reviewable changes (7)
  • group_vars/artemis_production.yml
  • group_vars/artemistest1.yml
  • group_vars/artemis_staging1.yml
  • group_vars/artemistest3.yml
  • group_vars/artemis_staging2.yml
  • group_vars/artemis_staging_localci.yml
  • group_vars/artemistest2.yml

📝 Walkthrough

Walkthrough

The PR removes restricted_modules from Athena-related group vars in production, staging, and local CI, and from test environment group vars. The remaining url and secret entries stay in place.

Changes

Athena config cleanup

Layer / File(s) Summary
Remove restricted modules
group_vars/artemis_production.yml, group_vars/artemis_staging1.yml, group_vars/artemis_staging2.yml, group_vars/artemis_staging_localci.yml, group_vars/artemistest1.yml, group_vars/artemistest2.yml, group_vars/artemistest3.yml
restricted_modules is removed from the Athena configuration in the Artemis environments and from the standalone test group var entries.

🎯 2 (Simple) | ⏱️ ~10 minutes

A bunny hops by with a tidy little grin,
restricted_modules is gone — let the cleanup begin.
url and secret still sparkle just right,
In staging and tests, the configs feel light.
Hoppity yay, from whiskers to tail 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing Athena's restricted_modules configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-athena-restricted-modules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bensofficial
bensofficial merged commit fedb1b2 into main Jun 29, 2026
2 checks passed
@bensofficial
bensofficial deleted the remove-athena-restricted-modules branch June 29, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants