[keymgr_dpe] Replace keymgr in EG - PR8 crypto driver - #30677
Merged
andreaskurth merged 3 commits intoAug 3, 2026
Conversation
Contributor
Author
|
DO NOT MERGE THIS PR This PR cannot be merged until the following PR passes the CI: The introduced keymgr_dpe drivers are not yet referenced in any build system until the TOP integration PR. Therefore none of the CI checks really verifies anything in this PR. The only reason for this PR is to break down the review effort into several smaller chunks of work along "logical" lines of code spaces. |
nasahlpa
approved these changes
Jul 7, 2026
nasahlpa
left a comment
nasahlpa
left a comment
Contributor
There was a problem hiding this comment.
Thanks Raphael, I had a look into the last three commits.
The first commit I already have reviewed in another repo.
The other two commits LGTM!
| @@ -0,0 +1,212 @@ | |||
| // Copyright lowRISC contributors (OpenTitan project). | |||
Contributor
There was a problem hiding this comment.
I think you should be able to already add this test to the BUILD file but just mark it as broken such that it is not build and executed.
nasahlpa
approved these changes
Jul 7, 2026
nasahlpa
left a comment
nasahlpa
left a comment
Contributor
There was a problem hiding this comment.
Thanks Raphael - I had a look into the last three commits:
- The first commit I already have reviewed in another repo
- The last two commits look good to me, they streamline the cryptolib drivers with upstream as well as adding a new test
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR8_cryptolib
branch
from
July 7, 2026 14:59
e167c75 to
910b63b
Compare
5 tasks
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR8_cryptolib
branch
from
July 13, 2026 07:21
910b63b to
a8dc659
Compare
gautschimi
reviewed
Jul 13, 2026
rroth-lowrisc
marked this pull request as ready for review
July 16, 2026 12:45
rroth-lowrisc
requested review from
alees24,
h-filali and
rswarbrick
and removed request for
a team,
alees24 and
rswarbrick
July 16, 2026 12:45
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR8_cryptolib
branch
from
July 24, 2026 10:23
a8dc659 to
586a894
Compare
h-filali
reviewed
Jul 24, 2026
h-filali
left a comment
h-filali
left a comment
Contributor
There was a problem hiding this comment.
Thanks for implementing this. A couple of nits and questions but this looks very good in general!
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR8_cryptolib
branch
2 times, most recently
from
July 29, 2026 13:02
612651c to
456888c
Compare
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR8_cryptolib
branch
3 times, most recently
from
July 31, 2026 16:25
db2982a to
9ba31df
Compare
To ensure backwards compatibility, the file has been split into two sections due to the different boot processes. The first part covers the boot process for darjeeling and the second part covers the boot process for earlgrey. This `if define ...` should either be replaced with two testutils files for the `keymgr_dpe` (linked by Bazel according to the top) or with a finer granularity of defines (e.g. function-wise) Signed-off-by: Raphael Roth <rroth@lowrisc.org>
This commit introduces a first version of the keymgr_dpe sw in the crypto lib. It covers the basic keymgr_dpe features. Add source / header file **without** linking them in the appropriate BUILD file as some dependencies do not exist yet! This commit contains the backported changes from the following git commit hashes (changes done in `keymgr` but relevant for `keymgr_dpe` too): - 9dcbb05 [sw] Fix missing switch default labels - 4afe7cd [crypto] Move entropy_init and check - ab8c166 [coverage/drivers] Add comments to unreached lines - b10d2fe [crypto] Add laundered otcrypto ok status - e587303 [crypto] Remove coverage remarks - 068c37e [crypto] Fix usage of launder32() Signed-off-by: Raphael Roth <rroth@lowrisc.org>
This commit introduces the test for the `keymgr_dpe` driver inside the crypto lib. It covers the basic `keymgr_dpe` features. Add source / header file **without** linking them in the appropriate BUILD file as some dependencies do not exist yet! Signed-off-by: Raphael Roth <rroth@lowrisc.org>
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR8_cryptolib
branch
from
August 3, 2026 07:23
9ba31df to
b2559c9
Compare
Contributor
Author
|
This PR also includes PR7 (#30670) which is also approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR8 - crypto driver
This PR is the eight in a series which will replace the keymgr with the kemgr_dpe in earlgrey. The replacement was approved by this RFC.
Merge-Dependencies
Relevant Commits
Last
threetwo commitDescription
This PR will add a first version of the crypto lib driver for the
keymgr_dpe. It adds the basic functionality to interact with thekeymgr_dpe. A first draft version of thekeymgr_dpe_testis already present, however some commits needs to be backported from themasterbranch first.It is not yet included in the bazel build system as several dependencies are missing until the top integration is finished.