[lint] Waive VAR_INDEX_RANGE warnings shown in new tool versions#30671
Merged
Conversation
The corresponding RTL is okay, the computed index is always valid. Otherwise, we end up in a different branch and the index is not used. It's okay to waive this warning. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
The corresponding RTL is okay. As the LSBs are fixed to 5'd31, the resulting index is always valid and greater equal 0. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
glaserf
approved these changes
Jul 6, 2026
glaserf
left a comment
glaserf
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking care of this and cleaning up my mess in CSRNG!
nasahlpa
approved these changes
Jul 6, 2026
nasahlpa
left a comment
nasahlpa
left a comment
Contributor
There was a problem hiding this comment.
Thanks Pirmin, this looks correct.
Contributor
|
CHANGE AUTHORIZED: hw/ip/csrng/rtl/csrng_ctr_drbg.sv No functional change - only a comment was added a lint waiver was added. |
Contributor
Author
|
CHANGE AUTHORIZED: hw/ip/csrng/rtl/csrng_ctr_drbg.sv No functional change - only a comment was added a lint waiver was added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once these changes are in, we can upgrade the tool version used in CI with what is used in the development environment.