check-pr-changes-allowed.py now considers review comments#30493
Conversation
Updated so the script now looks at regular comments and review comments when looking for "CHANGE AUTHORIZED: " before allow a PR to be merged. Signed-off-by: Ed Baker <edward.baker@lowrisc.org>
Ed-Baker1
force-pushed
the
fix-pr-auth-comments
branch
from
00407ca to
0192fd7
Compare
There was a problem hiding this comment.
Thanks @Ed-Baker1 ! This is a nice usability fix.
As this is an important feature to prevent accidental changes to significant files in the tree, I will wait for another review before authorizing and merging.
@rswarbrick @vogelpi PTAL
|
CHANGE AUTHORIZED: ci/scripts/check-pr-changes-allowed.py This PR just changes the script to also look for CHANGE AUTHORIZED comments in the review comments. |
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
Looks sensible to me (and I'm thrilled to see that there's such a clean solution!)
|
CHANGE AUTHORIZED: ci/scripts/check-pr-changes-allowed.py This change is to match the desired behaviour of the script. Definitely no "risk to the design" :-) |
|
Failing FPGA tests are clearly unrelated to this CI workflow tooling change. |
4 participants
Updated so the script now looks at regular comments and review comments when looking for "CHANGE AUTHORIZED: " before allow a PR to be merged.
Fixes #29864