feat(coordinator) Add DP-rank pinning parity to the coordinator's kv-nixl connector - #2480
Draft
roytman wants to merge 2 commits into
Draft
feat(coordinator) Add DP-rank pinning parity to the coordinator's kv-nixl connector#2480roytman wants to merge 2 commits into
roytman wants to merge 2 commits into
Conversation
Signed-off-by: roytman <roytman@il.ibm.com>
Signed-off-by: roytman <roytman@il.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The sidecar's nixlv2 KV connector pins a disaggregated request's prefill and decode legs to the same vLLM data-parallel rank via the x-data-parallel-rank header, guarding against SO_REUSEPORT-sharing DP backends routing the two legs to different ranks. The coordinator's equivalent connector, kv-nixl, had no DP awareness at all.
This adds the same behavior to the coordinator:
New pipeline.dp_size config option (default 1, disabled), merged into step params the same way kv_connector/ec_connector already are.
kv-nixl hashes the request ID into a deterministic rank and sets it as the x-data-parallel-rank header on both the prefill and decode requests, preferring a remote_dp_rank the prefill response echoes back when present. kv-sglang and kv-shared-storage are unaffected — their sidecar equivalents never reference DP rank either.
No kv_transfer_params body field changes; this is header-only, matching the sidecar's plain (non-MoRI-IO) NIXLv2 behavior.
Which issue(s) this PR fixes:
Fixes #2478
Release note (write
NONEif no user-facing change):